Open
Conversation
Chudopal
reviewed
May 26, 2022
| SHOPPING_RESULT = [] | ||
| COAST_LIST= [] | ||
| DICT = {} | ||
| class With_File_Working(): |
Owner
There was a problem hiding this comment.
Именование классов пишется без _, то есть вместо With_File_Working нужно написать WithFileWorking
| self._path = path | ||
| self.name = name | ||
|
|
||
| def read_file(adress, name) -> List: |
Owner
There was a problem hiding this comment.
нужно передать параметр self, и через него получать _path, а не передавать его в функцию явно
| return data.get(name) | ||
|
|
||
| def user_menu() -> str: | ||
| def write_file(adress, data) -> None: |
Owner
There was a problem hiding this comment.
тоже, прокинуть self и из него получать _path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.